Skip to content

bench(bitpacking): more representative unpack_indices benchmarks - #194

Merged
lwwmanning merged 1 commit into
developfrom
wm/runtime-unpack-benchmarks
Sep 1, 2026
Merged

bench(bitpacking): more representative unpack_indices benchmarks#194
lwwmanning merged 1 commit into
developfrom
wm/runtime-unpack-benchmarks

Conversation

@lwwmanning

@lwwmanning lwwmanning commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

The benchmarks from #190 did not compare the three paths fairly. The compiler treated the bit width as a constant for some paths and removed work that real callers still do. This PR gives every path the same runtime bit width and covers all four integer types near the candidate cutoffs.

It also restores extraneous code comment removals in #190 and makes the new tests fail safely if an unpack method skips an output.

@codspeed-hq

codspeed-hq Bot commented Sep 1, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 35.71%

❌ 1 regressed benchmark
✅ 157 untouched benchmarks
🆕 48 new benchmarks
⏩ 171 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation throughput_compress 1.5 ms 2.3 ms -35.71%
🆕 Simulation batched[1] N/A 1.3 µs N/A
🆕 Simulation batched[32] N/A 4 µs N/A
🆕 Simulation batched[48] N/A 4.3 µs N/A
🆕 Simulation batched[8] N/A 2.3 µs N/A
🆕 Simulation full_unpack_then_gather[1] N/A 4.4 µs N/A
🆕 Simulation full_unpack_then_gather[32] N/A 4.9 µs N/A
🆕 Simulation full_unpack_then_gather[48] N/A 5.2 µs N/A
🆕 Simulation full_unpack_then_gather[8] N/A 4.5 µs N/A
🆕 Simulation repeated_single[1] N/A 1 µs N/A
🆕 Simulation repeated_single[32] N/A 4 µs N/A
🆕 Simulation repeated_single[48] N/A 4.5 µs N/A
🆕 Simulation repeated_single[8] N/A 2.1 µs N/A
🆕 Simulation batched[1] N/A 1.3 µs N/A
🆕 Simulation batched[64] N/A 6.2 µs N/A
🆕 Simulation batched[8] N/A 2.4 µs N/A
🆕 Simulation batched[80] N/A 6.6 µs N/A
🆕 Simulation full_unpack_then_gather[1] N/A 7.3 µs N/A
🆕 Simulation full_unpack_then_gather[64] N/A 8.5 µs N/A
🆕 Simulation full_unpack_then_gather[8] N/A 7.4 µs N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing wm/runtime-unpack-benchmarks (d85faa0) with develop (069f29d)

Open in CodSpeed

Footnotes

  1. 171 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@lwwmanning lwwmanning changed the title test(bitpacking): Correct indexed unpack benchmarks bench(bitpacking): more representative unpack_indices benchmarks Sep 1, 2026
@lwwmanning
lwwmanning marked this pull request as ready for review September 1, 2026 20:52
@lwwmanning
lwwmanning enabled auto-merge (squash) September 1, 2026 20:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-01T20:54:51.158963Z d85faa0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lwwmanning
lwwmanning merged commit f610cfd into develop Sep 1, 2026
4 of 5 checks passed
@lwwmanning
lwwmanning deleted the wm/runtime-unpack-benchmarks branch September 1, 2026 21:09
@github-actions github-actions Bot mentioned this pull request Sep 1, 2026
Merged
lwwmanning pushed a commit that referenced this pull request Sep 1, 2026
@github-actions
chore: release v0.7.1 (#193)
325a8b7 
## 🤖 New release

* `fastlanes`: 0.7.0 -> 0.7.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.7.1](v0.7.0...v0.7.1) -
2026-09-01

### Added

- *(bitpacking)* Add batched index unpacking
([#190](#190))

### Other

- *(bitpacking)* more representative unpack_indices benchmarks
([#194](#194))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes
@AdamGS AdamGS AdamGS approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lwwmanning @robert3005 @AdamGS